search

flyinghead / flycast

Flycast is a multiplatform Sega Dreamcast, Naomi, Naomi 2 and Atomiswave emulator
GNU General Public License v2.0
1.39k stars 168 forks source link

Widescreen hack + Widescreen cheats sums each other #1551

Open kokoko3k opened 3 months ago

kokoko3k commented 3 months ago

Platform / OS / Hardware: X86_64/Archlinux/intel IGP

Github hash: v2.3-4-gf346bcd

Description of the Issue When enabling Widescreen Cheats and Widescreen Hack the picture becomes too large.

Debugging Steps Tested

Screenshots Screenshot_20240615_122801

Would it be possible to use some heuristic to understand if a rom has already been patched to wide screen? and disable the widescreen hack? Maybe we could add another option like: disable widescreen hack if final aspect ratio W/R exceeds a value like 1.6667 or 2.35 ?

flyinghead commented 3 months ago

Enabling both widescreen cheat and widescreen hack will result in a 2.37 aspect ratio. This is by design and some users prefer it this way. The simplest fix is to disable widescreen hack. I would prefer not to add yet another option to the already huge list of settings.

kokoko3k commented 3 months ago

My intent was that if the library contains a mix of wide patched and wide unpatched games, flycast could selectively apply wide hack to the unpatched ones.

I understand the downsides of having yet another option, so do you think it would be ok to selectively apply the wide hack by checking the output viewport aspect?

Something like: if hacked the game aspect is bigger than the output one by a certain hardcoded tolerance, then remove the widescreen hack?

nexus382 commented 3 months ago

"Cinama mode" we have named this. I like using it as super ultra wide screen when I play some games.... sonic adventure 1 Is one I love to see in this mode. I always leave both settings on...hoping that one of them work and makes my game full screen... but due to the fact some games are native 16:9, some use the hack, and some use the cheats ... u just gotta tinker at times. But if that's the price I must pay to enjoy my games in widescreen, [or super wide screen] ....well that is just the price I shall pay.... the fact flipping a few check boxes can mean I can play most games in atleast 16:9.... that's frigging amazing tbh...lol

kokoko3k commented 3 months ago

If I understood properly, there are many users like you that prefer some games to have black bars top and bottom? Read: 32:9 games on a 16:9 screen?

I'd rather prefer to have a target aspect ratio that matches the output viewport as close as possible (fill the screen as much as possible), hence my request to disable widescreen hacks if there is already a cheat that stretches the game in a (more) proper way. I mean, in the actual state sometimes we "move" left/right void space to upper/bottom.

Ps: I'm not aware of any native game on Dreamcast with a wide aspect! (?)

Pps: sorry for the multiple editings :-p