flyinghead / flycast

Flycast is a multiplatform Sega Dreamcast, Naomi, Naomi 2 and Atomiswave emulator
GNU General Public License v2.0
1.49k stars 175 forks source link

Cannot launch from Android ES-DE - Side Effect from Flycast 2.2 #1584

Closed nevmind closed 1 month ago

nevmind commented 4 months ago

Platform / OS / Hardware: Android

Precondition.

Test Procedure.

  1. Run ES-DE in Android.
  2. select button on any naomi game to set altemulator to "Flycast (Standalone)" which means Flycast standalone app.
  3. See if game is launched correctly or not.

Actual Result : Just display Flycast gamelist screen. and doens't start game.

Additional Info. : Flycast 2.0 : no problem Flycast 2.1 : no problem Flycast 2.2 : has problem Flycast 2.3 : has problem

Flycast 2.3.2-164-g33d1afdb in Android Playstore (Git Hash : 33d1afdb) : has problem and
1 more problem -> cannot be recognized as standalone emulator by following es_find_rules.xml of ES-DE

<emulator name="FLYCAST">
    <!-- Sega Dreamcast emulator Flycast -->
    <rule type="androidpackage">
        <entry>com.flycast.emulator/com.reicast.emulator.MainActivity</entry>
    </rule>
</emulator>

So, I have tried modifed following es_find_rules.xml -> can be recognized as standalone emulator but doesn't launch game.

<emulator name="FLYCAST">
    <!-- Sega Dreamcast emulator Flycast -->
    <rule type="androidpackage">
        <entry>com.flycast.emulator/com.flycast.emulator.MainActivity</entry>
    </rule>
</emulator>

Are u changing package name of MainActivity? Need to specify clearly to ES-DE team. So they can change es_find_rules.xml correctly.

nevmind commented 4 months ago

updated more information about this bug

flyinghead commented 4 months ago

This regression is due to this change: 87fdd203b57fae24ae25e30613726f6a8a6fb2a0, which was included in 2.2. I will push a fix soon.

I also changed the name of the main activity from com.reicast.emulator.MainActivityto com.flycast.emulator.MainActivity but this is a recent change and doesn't impact v2.2 or v2.3. The Google Play version does have this change as you found out.

SilverGreen93 commented 3 months ago

So is this something that needs fixing on flycast side? Or should we talk to ES-DE as well to update the activity name?

flyinghead commented 3 months ago

A fix is also needed on the Flycast side, which I haven't committed yet.

nevmind commented 3 months ago

When is next fixed version supposed to be released?

flyinghead commented 3 months ago

Fixed on Google Play

nevmind commented 3 months ago

Fixed on Google Play

Very Thanks. It works now!!!