search

flyinghu123 / CPR

The implement for paper : "Target before Shooting: Accurate Anomaly Detection and Localization under One Millisecond via Cascade Patch Retrieval"
https://arxiv.org/abs/2308.06748v1
MIT License
79 stars 7 forks source link

Seems Eq. (12) in the paper has something wrong. #3

Closed hurri2000 closed 10 months ago

hurri2000 commented 10 months ago

Capture I think it should be : ... yi max(0, dist_p - m+) + (1-yi)max(0,m- - dist_n), in this way, the dist_p gets smaller and dist_n gets greater. please check.

Thanks for your great working.

Best regards,

flyinghu123 commented 10 months ago

Capture I think it should be : ... yi max(0, dist_p - m+) + (1-yi)max(0,m- - dist_n), in this way, the dist_p gets smaller and dist_n gets greater. please check.

Thanks for your great working.

Best regards,

The inner product is cosin similarity, so it is max(m+- dist_ p)

hurri2000 commented 10 months ago

I see, thanks.