flyingmachine / emacs-for-clojure

519 stars 267 forks source link

editing.el and global-rainbow-delimiters-mode #34

Closed ClintRhea closed 6 years ago

ClintRhea commented 6 years ago

Per https://github.com/Fanael/rainbow-delimiters#global-mode:

There's no global-rainbow-delimiters-mode anymore. It used to exist, but it was impossible to keep it from breaking some major modes. It's strongly recommended to use major mode hooks instead, as shown above. There's nothing stopping you from defining global-rainbow-delimiters-mode yourself, but if it breaks something, you're on your own.

ClintRhea commented 6 years ago

I replaced the line in my editing.el with: (add-hook 'clojure-mode-hook #'rainbow-delimiters-mode)

ClintRhea commented 6 years ago

This is actually already solved by PR https://github.com/flyingmachine/emacs-for-clojure/pull/17