Open webbertakken opened 3 years ago
@webbertakken Thank you for reporting this, fun scenario :D
Regarding the shifting around of lines during toggle, I've had a couple of people mention a similar thing, and actually noticed this myself. In those cases, it had to do with the "ToggleMode".
Could you try this:
{
"ToggleMode": "Move"
}
It defaults to "Resize", which I've been considering changing due to the feedback so far. The "Resize" mode is meant for when using multiple monitors stacked above one another, which doesn't work great with "Move", since the terminal is pushed to the top screen and then dissappears.
I'd love to hear if that fixes that part of the problem at least!
@flyingpie I can confirm this fixes point 2 and 3. It even looks (feels) to be a bit smoother now as well.
@webbertakken Great! Now on to the point 1.
Pressing the hotkey to open the console while still open on a different screen or behind content does not open the console immediately but closes it instead. You'll have to press the same hotkey twice to effectively open it.
This is a thing that's been bothering for some time now. What do you think would be the proper way of handling this?
Eg. move terminal to the active monitor, whilst staying open?
Also, since there is a bit of overlap with the "hide when focus lost", in my experience, the terminal only does this when I move to another monitor but don't actually focus a different app. So it's sort of this twilight zone of focus-lost-but-also-not. So perhaps you're suggesting to be able to hide the terminal when moving the mouse to a different monitor?
@flyingpie Cool. Here are my thoughts.
What do you think would be the proper way of handling this?
Before using this console with powershell I used ConEmu with a mix of powershell and ubuntu bash (WSL) shells. ConEmu is highly configurable and I spent considerable time trying different configurations.
Behaviours:
A: Open regularly, with a smooth animation B: Close regularly, with an optional smooth animation C: quick or instant close then immediately open on the screen where the mouse pointer is.
Flows / cases when pressing the hotkey for open/close
The last case ended up being bugged sometimes, which ultimately led me to reduce the close animation time to 0ms.
there is a bit of overlap with the "hide when focus lost"
So I can mostly only speak from my own use case: when I click on a different screen (say my IDE) I do not want the terminal to close, because I might be reading something from it. This is the main use case for having the auto-hide disabled.
perhaps you're suggesting to be able to hide the terminal when moving the mouse to a different monitor
In my opinion it should only hide once you click outside the console itself, causing a real loss of focus. I believe that behaviour would be most reliable and predictable to the all users.
Exceptions to that (i.e. alt
+tab
should not count as focus lost) should probably have a separate setting or might not be worth the extra complexity at all.
This setting is set to true by default, ~and works perfectly as far as I can see~ (was able to reproduce with true as well).
When setting it to
false
, I observed the following behaviours that would not be expected for a great user experience.I will demonstrate case 3 by running
dir
before and after reopening the console:before reopening console:
after reopening console, before pressing enter
after pressing enter and scrolling up by 2 lines:
proposed solution: (for point 1)
proposed solution: (for point 2 and 3)
Tested on: