flyingpie / windows-terminal-quake

Enable Quake-style dropdown for (almost) any application.
https://wtq.flyingpie.nl
MIT License
598 stars 39 forks source link

Alignment settings not working #65

Closed Ugenx closed 3 years ago

Ugenx commented 3 years ago

The horizontal/vertical alignment settings don't seem to be respected for versions newer than v0.11. On my ultrawide monitor a full width dropdown is a bit much so I have it configured to appear on the left side and occupying about 50% of the monitor's width with a bit of padding at the top which works fine on 0.11 but any newer version ignores the vertical padding and horizontal left alignment settings completely. I can provide screenshots if necessary but here is the config in question:

{
    // The keys that can be used to toggle the terminal.
    // See "HotKeys" bellow for possible values.
    "HotKeys": [
        {
            "Modifiers": "Windows",
            "Key": "OemTilde"
        }
    ],

    // Whether to show notifications when the app starts and when the settings are reloaded.
    "Notifications": true,

    // Make the window see-through (applies to the entire window, including the title bar).
    // 0 (invisible) - 100 (opaque)
    "Opacity": 100,

    // How long the toggle up/down takes in milliseconds.
    "ToggleDurationMs": 0,

    // How much room to leave between the top of the terminal and the top of the screen.
    "VerticalOffset": 100,

    // How far the terminal should come down, in percentage (eg. 50 = half way, 100 = full screen).
    "VerticalScreenCoverage": 65,

    // When "HorizontalScreenCoverage" is below 100, this setting determines where the terminal is place horizontally.
    // "Center", "Left" or "Right".
    "HorizontalAlign": "Left",

    // How much horizontal space the terminal should use. When this is below 100, the terminal is centered.
    // This can also be above 100, which can be useful to compensate for the window not always taking a 100% of the screen width,
    // due to the terminal being bound to column widths (eg. try 100.5 or 101).
    "HorizontalScreenCoverage": 55,

    // When clicking or alt-tabbing away to another app, the terminal will automatically (and instantly) hide.
    "HideOnFocusLost": true,

    // Whether to keep the terminal window always on top (requires restart).
    "AlwaysOnTop": false

    // # HotKeys
    // ## Modifiers
    // Alt, Control, Shift, Windows
    //
    // ## Key
    // ### Special keys
    // Alt, Back, CapsLock, Control, Escape, LControlKey, LShiftKey, LWin, RControlKey, RShiftKey, RWin, Shift, Space, Tab
    //
    // ### Middle part of the keyboard
    // Delete, End, Home, Insert, PageDown, PageUp, PrintScreen
    // Down, Left, Right, Up
    //
    // ### Number keys
    // D0 - D9
    //
    // ### Letters
    // A-Z
    //
    // ### Numpad
    // NumPad0 - NumPad9
    // Add, Decimal, Divide, Multiply, NumLock, Separator, Subtract
    //
    // ### Function keys
    // F1 - F24
    //
    // ### Special characters
    // OemBackslash, OemClear, OemCloseBrackets, Oemcomma, OemMinus, OemOpenBrackets,
    // OemPeriod, OemPipe, Oemplus, OemQuestion, OemQuotes, OemSemicolon, Oemtilde
    // Oem1 - Oem8, Oem102
}
meluskyc commented 3 years ago

I am also experiencing this issue. Commit 428d166 seems to have broke this.

flyingpie commented 3 years ago

@Ugenx @meluskyc Thank you for reporting this, I'm gonna try and fix this in the next release.

flyingpie commented 3 years ago

@Ugenx @meluskyc There's a new release available, and I've taken a closer look at the alignment, which should be working again.

Would you guys confirm this please? :)

meluskyc commented 3 years ago

Fixed for me. Thanks!

Ugenx commented 3 years ago

Looks good @flyingpie, thanks!

flyingpie commented 3 years ago

@meluskyc @Ugenx Thank you for reporting the issue and confirming the fix!