flyingpie / windows-terminal-quake

Enable Quake-style dropdown for (almost) any application.
https://wtq.flyingpie.nl
MIT License
598 stars 39 forks source link

Should open Windows Terminal if not already started #68

Closed vertti closed 6 months ago

vertti commented 3 years ago

Feature Request: I've put windows-terminal-quake to startup directory. So I'd love that it would start Windows Terminal if one is not already running. Not it just fails with a warning popup.

flyingpie commented 3 years ago

Hello @vertti, thank you for reporting this issue! This should actually already happen, could you provide the warning to see why wtq is not starting wt?

vertti commented 3 years ago

cannotfind

That is what pops up when starting the quake 1.1.1 when I do not have Windows Terminal running. If I start Windows Terminal my self and after that the quake, everything works.

flyingpie commented 3 years ago

@vertti That's weird, what happens if you enter "wt" on the command line?

flyingpie commented 3 years ago

Also, I think this might be the same issue as reported here: #61. Fellow fmiqbal points out that repairing the Windows Terminal installation fixed the issue. He also wasn't able to run "wt" separately, so I'd like to know whether that does work on your machine.

vertti commented 3 years ago

Running C:\Users\vertti\AppData\Local\Microsoft\WindowsApps\wt.exe from command line works. I also tried running the Settings -> Apps -> Windows Terminal -> Repair. Still get the error from quake if Windows Terminal is not already running.

flyingpie commented 3 years ago

@vertti I've uploaded a new release with a new setting called "WindowsTerminalCommand", which controls the actual command that is used to start Windows Terminal, if it isn't running already.

Could you try to run this version with a setting such as:

{
    "WindowsTerminalCommand": "C:\\Users\\vertti\\AppData\\Local\\Microsoft\\WindowsApps\\wt.exe"
}

I'm not sure why the app isn't finding wt.exe (which is the default command), but perhaps we can find something by messing around with the command.

It's release 'windows-terminal-quake-1.2.0-2021-04-30_1752.zip' here:

https://github.com/flyingpie/windows-terminal-quake/releases/tag/v1.2.0

juventus18 commented 3 years ago

sounds like you need to put windows terminal folder into your PATH env variable

flyingpie commented 3 years ago

@juventus18 True, but as far as I know, shouldn't that be done by the Windows Terminal installation?

vertti commented 3 years ago

@flyingpie thanks, works great!

At least for me, installing WT from Microsoft Store, it does not add it to the PATH.

ghost commented 3 years ago

can this be extended to allow terminals other than Windows Terminal?

flyingpie commented 3 years ago

@untoreh It should, which one are you wanting to use?

ghost commented 3 years ago

@flyingpie wezterm

flyingpie commented 3 years ago

@untoreh There is currently some Windows Terminal-specific stuff going on, but I don't see too much of a problem adding support for this.

Though, it's a little off-topic for this issue, could you open a new one with that specific feature request?

justinledwards commented 3 years ago

This issue is actually because of how microsoft is doing application aliases. To run the newer version of windows terminal I had to disable the old one launched via the alias. The exe itself is 0 bytes if you look.

image

flyingpie commented 3 years ago

@justinledwards Thank you so much for reporting this! Saved us a ton of time :D I'll add this to the docs.