Closed dependabot[bot] closed 4 months ago
@pbrant What do you think about upgrading from Java 11 to Java 17?
I personally like it, and I upgrade my library https://github.com/selenide/selenide to Java 17 few months ago. But most other libraries still work on Java 11 (Selenium, JUnit, AssertJ etc.).
I suggest a whole set of different branches for the various Java versions, like here: https://github.com/LibrePDF/OpenPDF/blob/master/CONTRIBUTING.md#compatibility-matrix
@andreasrosdal Thank you for the suggestion. Basically it means that we can easily upgrade to Java 17 (say, in FS 9.6.0), and IF some time later we need to patch some of previous version, we can release a patch in branch 9.5.x. But most probably we will never need to do it. :)
I like the idea.
Sounds reasonable to me too. JDK 11 and 17 have the same prospective support EOL, see e.g. https://adoptium.net/support/.
I'll admit I was slightly nervous about dropping JDK 8 support since it is still supported for another 2+ years and I suspect we do have users who are still stuck on it for whatever reason, but a) we haven't gotten any push back there and b) those folks probably aren't tracking the latest release anyway. Going from JDK 11 to 17 seems like a small step in comparison.
On Mon, Feb 26, 2024 at 8:34 AM Andrei Solntsev @.***> wrote:
@andreasrosdal https://github.com/andreasrosdal Thank you for the suggestion. Basically it means that we can easily upgrade to Java 17 (say, in FS 9.6.0), and IF some time later we need to patch some of previous version, we can release a patch in branch 9.5.x. But most probably we will never need to do it. :)
I like the idea.
— Reply to this email directly, view it on GitHub https://github.com/flyingsaucerproject/flyingsaucer/pull/274#issuecomment-1963480288, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAF42AIRFKHKBXAVTMF4RTYVQ3ILAVCNFSM6AAAAABDOSJVR6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRTGQ4DAMRYHA . You are receiving this because you were mentioned.Message ID: @.***>
Bumps com.github.librepdf:openpdf from 1.3.40 to 2.0.0.
Release notes
Sourced from com.github.librepdf:openpdf's releases.
Commits
c6027b5
Fix for issues #1047 (#1050)6bda8c2
Update 2.0.0.md873dd97
Rename changelogfile.8398aa2
2.0.0-SNAPSHOTdcd0bbd
Update 1.4.0.mda5a66b1
Update 1.4.0.mdae56f82
Specify Java version of codeql.yml.98c1535
Specify version for mockito-core.5d86f68
Require Java 17 for OpenPDF 1.4.0.c6725d6
Create 1.4.0.mdDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show