Add support for ROS noetic

flynneva / udp_msgs

ROS2 udp_msgs package

MIT License

0 stars 1 forks source link

Add support for ROS noetic #14

Closed jpbusch closed 9 months ago

jpbusch commented 10 months ago

modified CMakeLists.txt and package.xml to enable parallel ROS and ROS 2 build of udp_msgs

@flynneva, could you please review and then release for ROS noetic? Let me know if any further changes are required.

jpbusch commented 10 months ago

Hi @flynneva, I would appreciate getting feedback from you.

flynneva commented 10 months ago

@jpbusch sorry for just seeing this now. I'll take a look tomorrow and get back to you!

flynneva commented 9 months ago

@jpbusch I'd be fine with these changes, but do you think you could also add an action to the CI pipeline for Noetic then too? If not, no biggie I can add one in another PR since I need to update the ROS 2 ones anyways

jpbusch commented 9 months ago

@flynneva, thanks for reviewing! I have extended the CI to include ROS noetic. Unfortunately it was not possible to extend the current matrix strategy in ros_ci.yml, so I had to add another job. The action-ros-ci needs a different parameter for ROS 1 (target-ros1-distro).

flynneva commented 9 months ago

@jpbusch perfect. Once the CI passes I'll merge it and do a release, thanks again for the contribution 🙏🏼

jpbusch commented 9 months ago

Great, thank you, @flynneva!

flynneva commented 9 months ago

@jpbusch ill see about cutting a new release tomorrow if I can find the time 👍 thanks for the contributions!