search

flyntwp / flynt-cli

CLI tool for the WordPress Flynt framework
MIT License
14 stars 3 forks source link

composer conflict on flynt create #93

Open bdebrie opened 5 years ago

bdebrie commented 5 years ago

Since this Bedrock update https://github.com/roots/bedrock/pull/412 the flynt create command is not working anymore because of a conflict during requireComposerPackages.

This comes from the fact that the philippbaschke/acf-pro-installer package that is explicitly requiring a ^2.2 version of phpdotenv, while bedrock asks for a ^3

It has already been reported and a PR is already available https://github.com/PhilippBaschke/acf-pro-installer/issues/38, yet it seems that it is unclear if the repo is still alive and if this will get merged soon.

In the discussion someone created a new repo as an alternative, which supports phpdotenv ^3 https://github.com/ffraenz/private-composer-installer

bdebrie commented 5 years ago

Any thoughts or feedback regarding this ? @domtra @Qakulukiam

nilsbosman commented 5 years ago

I'm also running into this issue. Any status updates regarding this?

bdebrie commented 5 years ago

Hi @nilsbosman, from what I saw, this is not fixed. The workaround is to launch flynt create, and then go to composer.json after the installation fails. There you have to

bdebrie commented 5 years ago

The solution above was working two weeks ago but not anymore.

Easiest fix is to not put an acf pro key when the cli asks for it, and then manually add the acf plugin once the project is created.

nilsbosman commented 5 years ago

Hi @bdebrie, thanks for the help, for me it also didn't work. I'll try your new suggestion. However I did notice that they've changed the readme and it now says this repo is no longer under active development and refer to https://github.com/flyntwp/flynt with instructions on how to use the latest version of Flynt.

domtra commented 5 years ago

Hi @bdebrie and @nilsbosman, the solution for broken acf pro installs on create should be to not provide a acf pro key, as @bdebrie stated. we actually never used this way of installing acf pro, so i cannot really give you feedback to this.

regarding the deprecation: we made some really big changes to the flynt-starter-theme. the result, ongoing in development but already used on a couple of production sites, can be found in the https://github.com/flyntwp/flynt. our goal was to simplify every aspect of flynt. the theme can actually be dropped into any wordpress installation, bedrock or regular, and it will work. so there is not really a need for the flynt-cli anymore. for migrating data between environment, the wp cli is really handy and some manual rsync.

we will keep you updated about the development. the only info about the new flynt is actually currently in the readme of the mentioned github repo. if you have any questions, feel free to ask.