feat: add new social share component

flyntwp / flynt

Component based WordPress starter theme, powered by ACF Pro and Timber, optimized for a11y and fast page load results.

https://flyntwp.com

MIT License

735 stars 84 forks source link

feat: add new social share component #437

Closed stefanobartoletti closed 2 years ago

stefanobartoletti commented 2 years ago

This PR is about #430

This component simply adds some social sharing buttons.

Some considerations:

I have styled the buttons as few as possible, to make the component be more consistent with the overall look of the theme.
Only a few social networks are included, mainly because the Feather icon theme seems to support only a few brand icons.
Social sharing URLs and their parameters were taken from this documentation
Social network colors were taken from https://brandcolors.net/

Please let me know if this PR is fine as it is or if you think that something should be modified :)

timohubois commented 2 years ago

@stefanobartoletti first: Thank you for the great work and the PR. Currently, we are working on the next version of Flynt and we think, that we should only provide a as less as possible amount of components from the core, to focus more on a boilerplate approach and for now we need to close this PR.

But we are also internally thinking about a more elegant way to share custom made components. What would you like to see? And what would you expect from this feature?

I am very much looking forward to your feedback!

stefanobartoletti commented 2 years ago

I understand, this is not a problem :)

I'm not currently using Flynt, when working on Wordpress I mainly use a theme of my own creation, https://github.com/stefanobartoletti/bricks, I found on Flynt some interesting ideas and a component concept that was also what I had in mind for Bricks.

Anyway let me know if you need some other kind of feedback.