Stop exporting development files

flyntwp / flynt

Component based WordPress starter theme, powered by ACF Pro and Timber, optimized for a11y and fast page load results.

https://flyntwp.com

MIT License

734 stars 84 forks source link

Stop exporting development files #495

Closed szepeviktor closed 1 year ago

szepeviktor commented 1 year ago

There is how to test what gets into GitHub ZIP files.

git archive HEAD | tar --list

aaronmeder commented 1 year ago

@timohubois @szepeviktor

I noticed this change when checking out the wonderful Flynt v2 today (I downloaded the zip 😉). Why is this a desired behaviour? Would like to understand.

Since Flynt is a developer starter theme, not a theme to use right away without dev work it seems more suitable to me to include the files - what do you guys think? Not having files like the vite config available seems a bit counter-intuitive to me.

Thanks for clarifying. Aaron

szepeviktor commented 1 year ago

@aaronmeder It is very simple.

When you develop you issue the git clone command and start committing. export-ignore does not influence that.

When you add Flynt as a dependency you do not need development files in vendor/.

I think that is all.

szepeviktor commented 1 year ago

... I suspect that you develop without git - that is something @timohubois will answer.

aaronmeder commented 1 year ago

@aaronmeder It is very simple.

When you develop you issue the git clone command and start committing. export-ignore does not influence that.

When you add Flynt as a dependency you do not need development files in vendor/.

I think that is all.

Hey @szepeviktor yep it's clear to me that working with Git clone is not impacted. That's the way I usually work when creating a new theme based on Flynt. Sometimes I go and download a zip of the repo to look at the files in my code editor - which was what I was doing to get a first look at Flynt 2 but then realized the ZIP was missing some files.

I however don't get what you mean by "When you add Flynt as a dependency" - how would that work and in which situation would someone do that? As far as I know Flynt doesn't support a parent/child theme setup. Thanks for helping me understand.

szepeviktor commented 1 year ago

I see! Flynt is a starter theme for WordPress, not a library. So it cannot be used as a dependency. I've never used Flynt, I am a devops person.

❗ flynt-core was the library.

Then please revert my commit as each and every file is needed. ... maybe you could change the package name in composer.json to something generic like company/flynt-based-theme