search

flyntwp / flynt

Component based WordPress starter theme, powered by ACF Pro and Timber, optimized for a11y and fast page load results.
https://flyntwp.com
MIT License
722 stars 82 forks source link

Upgrade Scrutinizr OS #496

Closed szepeviktor closed 1 year ago

szepeviktor commented 1 year ago

Nodejs v18 needs modern libc. https://scrutinizer-ci.com/docs/guides/upgrading-trusty-image

timohubois commented 1 year ago

@domtra can you take a look on it?

szepeviktor commented 1 year ago

@timohubois Turns out the file name had a typo! .scrutinizer.yml

You need a devops person like viktor and say goodbye to services like Scrutinizer.

szepeviktor commented 1 year ago

node: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.28' not found (required by node)

Still older libc than necessary. Upgrading OS ...

szepeviktor commented 1 year ago

This is a waste of time. Scrutinizer and Codacy are not specialized services. Mediocre quality.

szepeviktor commented 1 year ago

I give up.

domtra commented 1 year ago

@szepeviktor thanks for your effort.

It seems to be impossible to get PHP 8.0 and node 18.x running under any of the scrutinizer images. I might try it with a custom image or use PHP 8.1 instead of 8.0.

When this was working, it gave us a simple guideline with a code quality score from 0-10. This was very convenient. However, the service seems to be a bit outdated and it is not quite active. I have tried some other services yesterday, mainly the ones that have github app integration and are recommended. all of them 'worked', but i did not like the results that came out of the box.

I know that you are big on static analysis, but honestly, i (currently) do not want to add extra dependencies just for static analysis. I would rather have a service like scrutinizer with one rating that takes multiple issues into account. Can you recommend any service that has free tiers for open source?

I really appreciate your quest for high coding standards. Thanks again!

szepeviktor commented 1 year ago

Although I'm still a TravisCI advocate people does not seem to be able ask for credits bimonthly.

I have near zero knowledge of working viktor-less!

But I could contribute a complete CI checking for every problem I have ever met. It is called byte-level care. What do you think?

szepeviktor commented 1 year ago

I could help keeping potential problems/bugs/tech debt at Zero.