flytaly / reddit-post-notifier

Firefox/Chrome extension that watches for posts in given subreddits or reddit searches
Mozilla Public License 2.0
20 stars 5 forks source link

Feature request: sound notification #1

Closed juandiegoabijah closed 5 years ago

juandiegoabijah commented 5 years ago

Hey man, thank you very much for the addon, I like it very much. Would it be possible to add a sound notification? maybe with a toggle or something, your app is really fast when showing the notifications, but sometimes I'm not looking and I need to hear it in order to open the latest post

thanks in advance!

flytaly commented 5 years ago

Hello. There should be system notification sounds but it seems it doesn't work on Windows for some reasons. I added support for Notification Sound addon. Try to install it, it should help.

juandiegoabijah commented 5 years ago

ok awesome man, thank u very much!

juandiegoabijah commented 5 years ago

Hey! I tried it with the notification sound extension, but it isn't making any sound :(

flytaly commented 5 years ago

Hmm. Make sure this extension is updated to 1.1.0.

Capture

screenshot

juandiegoabijah commented 5 years ago

yep it is, I also checked if the notification sound extension was updated, the sound extension works as it should, but it's not like paired with your extension imagen

juandiegoabijah commented 5 years ago

ok I tested it by receiving a PM, which opens like a popup on the right bottom corner of the browser, and in that case it did sound! but it's not making any sound when a new post is made on one of the configured subreddits, which is the feature I'm interested in

juandiegoabijah commented 5 years ago

imagen this popup is the one I'm talking about

flytaly commented 5 years ago

Did you select this checkbox image ?

juandiegoabijah commented 5 years ago

ohh that's the issue then!! I just ticked it and now it sounds, thanks man, you're the best! :D I love your plugin