search

flyte / mqtt-io

Expose GPIO modules (Raspberry Pi, Beaglebone, PCF8754, PiFace2 etc.) and digital sensors (LM75 etc.) to an MQTT server for remote control and monitoring.
MIT License
461 stars 157 forks source link

added: air quality to bme680 sensor #314

Closed crssnd closed 5 months ago

crssnd commented 1 year ago

I exposed the gas and air_quality for the BME680 sensor, and also added an config example.

mschlenstedt commented 11 months ago

Good suggestion!

But you made maybe more changes then needed (e. g. logging). Maybe you should remove these things (maybe there are left from your tests?).

This would clean up your PR and makes it more readable (and checkable).

crssnd commented 11 months ago

Good suggestion!

But you made maybe more changes then needed (e. g. logging). Maybe you should remove these things (maybe there are left from your tests?).

This would clean up your PR and makes it more readable (and checkable).

removed the logging part

crssnd commented 11 months ago

anything else that you think should be changed?

crssnd commented 5 months ago

no feedback from the maintainers

mschlenstedt commented 5 months ago

I think it is worse to wait until somebody has time to review the PR. Developement is unfortunately not very active anymore...

@BenjiU @flyte ? Maybe you can check and include the PR? Air Quality is the main reason for this sensor... So it should be included.

JackGlobetrotter commented 3 months ago

@crssnd Thanks for your work, really appreciate it! I have tried your implementation, it seems to introduce quit a lot of noise into temperature and humidity readings during gas measurement (which is possibly due to heating of bme680). I made some little changes to avoid these readings during gas measurement. Will open an new PR if that is fine for you ?