search

flyte / mqtt-io

Expose GPIO modules (Raspberry Pi, Beaglebone, PCF8754, PiFace2 etc.) and digital sensors (LM75 etc.) to an MQTT server for remote control and monitoring.
MIT License
471 stars 159 forks source link

Support for ENS160 digital multi-gas sensor with multiple IAQ data (TVOC, eCO2, AQI) #371

Closed linucks closed 4 months ago

linucks commented 5 months ago

Based on adafruit-circuitpython-ens160

BenjiU commented 5 months ago

Hi @linucks, may you please fix the lint warnings in your ens160 module, so we can complete the PR?

************* Module mqtt_io.modules.sensor.ens160
mqtt_io/modules/sensor/ens160.py:74:0: C0301: Line too long (119/100) (line-too-long)
mqtt_io/modules/sensor/ens160.py:103:0: C0301: Line too long (101/100) (line-too-long)
mqtt_io/modules/sensor/ens160.py:115:0: C0301: Line too long (132/100) (line-too-long)
mqtt_io/modules/sensor/ens160.py:117:0: C0301: Line too long (118/100) (line-too-long)
mqtt_io/modules/sensor/ens160.py:118:0: C0301: Line too long (120/100) (line-too-long)

Thanks!

linucks commented 5 months ago

@BenjiU I've made the changes and it looks like everything is passing now.

Btw, is there any developer documentation? I ran:

poetry install
poetry run pylint -d fixme mqtt_io
poetry run mypy --show-error-codes --strict --no-warn-unused-ignores mqtt_io

which I got from the CI file.

It'd be helpful if there was a document detailing the steps to go through to submit a PR and I couldn't find one when I looked.

linucks commented 4 months ago

Hi. What's happened to this PR? Is there a reason that it hasn't been merged?