flytegg / ls-discord-bot

The Discord bot powering the LearnSpigot.com support server.
https://learnspigot.com/discord
21 stars 18 forks source link

Filter those who haven't sent messages in threads for contributors #84

Closed Nuckerr closed 1 month ago

Nuckerr commented 1 year ago

Explain the issue.

https://github.com/learnspigot/discord-bot/blob/70c36fc2d6a3e95c592493d5b15fb6bd7ca45568/src/main/kotlin/com/learnspigot/bot/manager/ForumManager.kt#L86-L92

To get contributors, it gets all thread members and does not filter those who have not sent any messages. This could be simple filter function. See https://github.com/learnspigot/discord-bot/blob/70c36fc2d6a3e95c592493d5b15fb6bd7ca45568/src/main/kotlin/com/learnspigot/bot/manager/ForumManager.kt#L89-L91 To see how to get message count.

How to recreate?

No response

Anything else?

No response

Tofpu commented 7 months ago

If I'm not mistaken, this has been addressed recently: https://github.com/flytegg/ls-discord-bot/pull/241

MLGPenguin commented 1 month ago

This is completed