Open StillLutto opened 6 months ago
@StillLutto what's the state of this? Is it something you believe is in a position to be reviewed and tested?
@joshbker Yes it most definitely is. Stephen was waiting to review it because he was contacting the minecraft-heads team for a better and more extensive api, I don't know how that ended though.
@StillLutto We could not agree on terms in the end.
For the record, I love your implementation here. Fits our theme nicely and looks like it could work well.
My only fear is that when sites like mc heads and the other ones have nearing 100,000 heads, I feel it a bit shameful to release with only 900+.
I absolutely want this contribution to be merged into the main project, but I want to work on getting more heads.
If you give me some time, I have a few tricks up my sleeve and will sort this issue.
@stephendotgg I completely agree, and if you can't get a deal, it's fine if it doesn't get implemented. Actually, I'd even prefer if you didn't implement this utility if you don't get a deal because it is quite scummy to do so with only 900+ heads. It's really sad that I only realized this when I was like halfway done making the util. c58690b
Btw, feel free to close this now.
This Pull Request was made to add a new util, #183. The utility in question is basically a place for people to find for custom heads they can then use in their worlds.
It looks something like this:
Features
/give
commandsCode Changes/Additions
heads
= current heads being displayedtotalHeads
= hold all the heads fetchedAPI
/give
command, 1.20+ commandsAditional information
All the information is fetched from headdb.org. It only contains 900 heads, sadly, but for now it's the only option. In the meantime, @stephendotgg is currently contacting the people from https://minecraft-heads.com/ to see if we can use it's api, which has 50.000+ heads.
Please do let me know if I have to change anything! Sorry in advance if this is a little scuffed, I made this in a hurry.