flytegg / plugin-portal

Minecraft plugin manager for downloading and updating plugins from the chatbar.
https://pluginportal.link
45 stars 9 forks source link

[Bug]: Formatting issues #61

Open Craftefix opened 2 days ago

Craftefix commented 2 days ago

Description

When using /pp install it doesnt filter for special characters so it has some issues with folders and filesystems

Minimal Reproduction

1./pp install Plan | Player Analytics A temporary "fix" is using the -byID argunent

2./pp install eBackup - Simple and reliable backups for your server! Supports FTP/SFTP! This always will save the plugin in _eBackup - Simple and reliable backups for your server! Supports _FTP with the jar named SFTP.jar_

Exception or Error

This bug will eventually create issues, especcially with feature #59 where the file could be saved in the unix/linux root dir "/" or user dir "~/" When the plugin has a " | " in its name it ignores all arguments behind it, and says its the wrong source. Also spaces can create issues with some plugins

Dump

https://mclo.gs/0VKWqht

Craftefix commented 2 days ago

The filder issue with ebackup got patched, but now it doesnt want to install at all, bc of a wrong source argunent

MLGPenguin commented 2 days ago

This is a duplicate of both #51 and #58

Craftefix commented 2 days ago

Yikes sorry for the work

Dawsson commented 1 day ago

2 is fixed