flyteorg / flyte

Scalable and flexible workflow orchestration platform that seamlessly unifies data, ML and analytics stacks.
https://flyte.org
Apache License 2.0
5.42k stars 581 forks source link

[Core Feature] Flytekit client-side validation of pod specs #1123

Open katrogan opened 3 years ago

katrogan commented 3 years ago

Motivation: Why do you think this is important? Before serializing a pod spec, we should validate it. Although we use the kube client library to generate pod spec constructs, we should explore using the api client to validate we can deserialize the pod spec before registering it.

Goal: What should the final outcome look like, ideally? Faster turn-around for catching client-side pod spec validation issues.

Describe alternatives you've considered The current solution of postponed debugging at execution time.

[Optional] Propose: Link/Inline OR Additional context If you have ideas about the implementation please propose the change. If inline keep it short, if larger then you link to an external document.

EngHabu commented 3 years ago

Mind clarifying what additional checks this would give us? is it possible to generate an invalid pod spec if we are using kube client library?

katrogan commented 3 years ago

@EngHabu yes, there's been multiple cases on slack where someone entered an instance of something instead of a list (e.g. volume mounts) and deserialization at execution time failed confusingly

github-actions[bot] commented 1 year ago

Hello 👋, This issue has been inactive for over 9 months. To help maintain a clean and focused backlog, we'll be marking this issue as stale and will close the issue if we detect no activity in the next 7 days. Thank you for your contribution and understanding! 🙏

github-actions[bot] commented 1 year ago

Hello 👋, This issue has been inactive for over 9 months and hasn't received any updates since it was marked as stale. We'll be closing this issue for now, but if you believe this issue is still relevant, please feel free to reopen it. Thank you for your contribution and understanding! 🙏

github-actions[bot] commented 1 month ago

Hello 👋, this issue has been inactive for over 9 months. To help maintain a clean and focused backlog, we'll be marking this issue as stale and will engage on it to decide if it is still applicable. Thank you for your contribution and understanding! 🙏