search

flyteorg / flyte

Scalable and flexible workflow orchestration platform that seamlessly unifies data, ML and analytics stacks.
https://flyte.org
Apache License 2.0
5.68k stars 639 forks source link

Generate Java gPRC stub #178

Closed honnix closed 11 months ago

honnix commented 4 years ago

Currently the docker image that is used to generate Java code from proto doesn't generate gPRC stub.

This is easily solvable by installing one more binary and tweak it a bit. To do that we will need to open source the image.

honnix commented 4 years ago

@kumare3 wdyt?

kumare3 commented 4 years ago

@honnix absolutely, we should be open sourcing it. I think I am also open to just starting a new repo outside and we can copy things over. Then use this open sourced alternative. Open sourcing sometimes can take too long. @jonathanburns do you think it is worth open sourcing lyft/protocgenerator? Or should we just bootstrap a new project in flyteorg/...?

kumare3 commented 4 years ago

I have moved it to milestone 3. I will work on this after tomorrow

EngHabu commented 4 years ago

@honnix Is this done as part of your https://github.com/spotify/flytekit-java OSS. Can we close this?

honnix commented 4 years ago

Yes it is done there. However it is still strange we don't generate stub here. flytekit-java as I remember doesn't distribute proto and rpc generated code. I will take a look at there first.

There is an ongoing PR in protocgenerator, and I think we could get Java fixed with little effort.

kumare3 commented 4 years ago

@honnix let me know if we should start merging the PR

github-actions[bot] commented 1 year ago

Hello 👋, This issue has been inactive for over 9 months. To help maintain a clean and focused backlog, we'll be marking this issue as stale and will close the issue if we detect no activity in the next 7 days. Thank you for your contribution and understanding! 🙏

github-actions[bot] commented 1 year ago

Hello 👋, This issue has been inactive for over 9 months and hasn't received any updates since it was marked as stale. We'll be closing this issue for now, but if you believe this issue is still relevant, please feel free to reopen it. Thank you for your contribution and understanding! 🙏

kumare3 commented 11 months ago

This has been completed

honnix commented 11 months ago

Do we have the gRPC stubs generated for Java? I don't see them here https://github.com/flyteorg/flyte/tree/master/flyteidl/gen/pb-java/flyteidl/service. Also it would be nice to get those generated classes compiled, packed and uploaded to Maven central. Unlike Go, Java doesn't do source code distribution.