flyteorg / flyte

Scalable and flexible workflow orchestration platform that seamlessly unifies data, ML and analytics stacks.
https://flyte.org
Apache License 2.0
5.45k stars 582 forks source link

[Core feature] add disable_default_launch_plan option in latest flytekit api #1847

Open ckiosidis opened 2 years ago

ckiosidis commented 2 years ago

Motivation: Why do you think this is important?

In the previous api (i think before ~v0.16.0) there was an option to disable the default launch plan

@workflow_class(disable_default_launch_plan=True)

This functionality hasn't been ported to the newer @workflow decorator.

Goal: What should the final outcome look like, ideally?

The @workflow decorator should have a disable_default_launch_plan=True option.

@workflow(disable_default_launch_plan=True)
...

Describe alternatives you've considered

Haven't considered any alternatives

Propose: Link/Inline OR Additional context

No response

Are you sure this issue hasn't been raised already?

Have you read the Code of Conduct?

welcome[bot] commented 2 years ago

Thank you for opening your first issue here! 🛠

honnix commented 1 year ago

Looks like this issue has not been addressed. Can we get some priority on it? Thank you.

github-actions[bot] commented 1 year ago

Hello 👋, This issue has been inactive for over 9 months. To help maintain a clean and focused backlog, we'll be marking this issue as stale and will close the issue if we detect no activity in the next 7 days. Thank you for your contribution and understanding! 🙏

honnix commented 1 year ago

I think this is still relevant?

github-actions[bot] commented 3 months ago

Hello 👋, this issue has been inactive for over 9 months. To help maintain a clean and focused backlog, we'll be marking this issue as stale and will engage on it to decide if it is still applicable. Thank you for your contribution and understanding! 🙏