flyteorg / flyte

Scalable and flexible workflow orchestration platform that seamlessly unifies data, ML and analytics stacks.
https://flyte.org
Apache License 2.0
5.19k stars 551 forks source link

[BUG] FLytectl pagination should use server returned token instead of page number #2016

Open pmahindrakar-oss opened 2 years ago

pmahindrakar-oss commented 2 years ago

Describe the bug

Currently flytectl computes the token using Page number and limit provided by the user from the commandline

https://github.com/flyteorg/flytectl/blob/64d399291fb6ed326c867eb5258fbf68de75f8ca/pkg/filters/util.go#L61

This will cause issues if the token implementation changes in flyteadmin.

Instead flytectl should rely on the token returned in the ListResponse for flyte entities and have the user pass it directly for fetching next set of results.

Expected behavior

O/p : Use the --filter.token server-returned-token to fetch the next set of results

Additional context to reproduce

No response

Screenshots

No response

Are you sure this issue hasn't been raised already?

Have you read the Code of Conduct?

github-actions[bot] commented 10 months ago

Hello 👋, This issue has been inactive for over 9 months. To help maintain a clean and focused backlog, we'll be marking this issue as stale and will close the issue if we detect no activity in the next 7 days. Thank you for your contribution and understanding! 🙏

github-actions[bot] commented 10 months ago

Hello 👋, This issue has been inactive for over 9 months and hasn't received any updates since it was marked as stale. We'll be closing this issue for now, but if you believe this issue is still relevant, please feel free to reopen it. Thank you for your contribution and understanding! 🙏