Open pmahindrakar-oss opened 2 years ago
Using JsonPBMarshaller for now
func WriteClusterConfigToFile(clusterConfig *cluster.ClusterConfig, fileName string) error {
JsonPbMarshaller := &jsonpb.Marshaler{}
str ,_ := JsonPbMarshaller.MarshalToString(clusterConfig)
d, err := yaml.JSONToYAML([]byte(str))
Hello π, This issue has been inactive for over 9 months. To help maintain a clean and focused backlog, we'll be marking this issue as stale and will close the issue if we detect no activity in the next 7 days. Thank you for your contribution and understanding! π
Hello π, This issue has been inactive for over 9 months and hasn't received any updates since it was marked as stale. We'll be closing this issue for now, but if you believe this issue is still relevant, please feel free to reopen it. Thank you for your contribution and understanding! π
Hello π, this issue has been inactive for over 9 months. To help maintain a clean and focused backlog, we'll be marking this issue as stale and will engage on it to decide if it is still applicable. Thank you for your contribution and understanding! π
Describe the issue
Current version of protoc-gen-doc being used generates the snake case version of the fields for json marshalling
Would be great if this behavior is customizable.
Currently the flytectl uses camelcase for all its commandline flags In some cases where we want to allow users to read/write such configs from json/yaml files and pass them to cli, then in the existing behavior it results in empty attributes due to this diff.
eg : while defining the commandline flag counterpart for the above ClusterConfig we define this way to match up with the json tag in the generated definition of ClusterConfig
Expected to keep the cli config using camel case and still be able to use ClusterConfig to write a yaml file in camelCase
What if we do not do this?
mixture of camel case and snake case or add customized unmarshalling
Related component(s)
No response
Are you sure this issue hasn't been raised already?
Have you read the Code of Conduct?