search

flyteorg / flyte

Scalable and flexible workflow orchestration platform that seamlessly unifies data, ML and analytics stacks.
https://flyte.org
Apache License 2.0
5.5k stars 592 forks source link

[Docs] Add information about behaviors of resource defaults and limits #2513

Open marc-union opened 2 years ago

marc-union commented 2 years ago

Description

We need clearer documentation about how Flyte sets resource defaults and limits.

From @katrogan :

Platform defaults are the defaults when no task level requests/limits are set. If only one task level request/limit is set AND that request is under the platform limit both values will be set to whichever value was set in the task. If only one task level request/limit is set AND that request is over the platform limit the unset value is set to the platform limit.

For full details, see the Slack thread below.

References:

https://flyte-org.slack.com/archives/C03CY9S9MFE/p1652970945750369

https://docs.flyte.org/en/latest/concepts/admin.html#task-resource-defaults

Are you sure this issue hasn't been raised already?

Have you read the Code of Conduct?

github-actions[bot] commented 1 year ago

Hello 👋, This issue has been inactive for over 9 months. To help maintain a clean and focused backlog, we'll be marking this issue as stale and will close the issue if we detect no activity in the next 7 days. Thank you for your contribution and understanding! 🙏

github-actions[bot] commented 1 year ago

Hello 👋, This issue has been inactive for over 9 months and hasn't received any updates since it was marked as stale. We'll be closing this issue for now, but if you believe this issue is still relevant, please feel free to reopen it. Thank you for your contribution and understanding! 🙏

kumare3 commented 9 months ago

the entire config system is getting overhauled. cc @katrogan ?

katrogan commented 9 months ago

only a proposal for now https://github.com/flyteorg/flyte/blob/master/rfc/system/3749-sane-overridable-defaults.md

but this issue is specifically for explaining what the config options mean (there is confusion between requests and defaults)

github-actions[bot] commented 2 weeks ago

Hello 👋, this issue has been inactive for over 9 months. To help maintain a clean and focused backlog, we'll be marking this issue as stale and will engage on it to decide if it is still applicable. Thank you for your contribution and understanding! 🙏

davidmirror-ops commented 2 weeks ago

Commenting to keep it open as this is still unresolved