Open brucearctor opened 2 years ago
Not sure whether needed, but made an issue - due to @jw0515's comment, as seems to warrant exploration.
By default the alb.ingress.kubernetes.io/target-type will be "instance" which only works for NodePort/LoadBalancer type: https://github.com/kubernetes-sigs/aws-load-balancer-controller/issues/1695
@jw0515 -- I can't explore this. Requires cloud compute resources ( AWS ), and that hasn't been set up for the Open Source project. There is only cloud resources and testing infra for Union employees. I don't want pay out of pocket for such cloud spend, so I'm not working on these sorts of things. I imagine that @EngHabu and team can take a look eventually.
Strong testing of the deployment guides to ensure nothing breaks with updates/changes is pretty critical.
Makes sense!
Hi, I went through the AWS deployment guide last night. I ran into this error and it's not at all the clearest thing to figure out what's wrong.
There were a few things I adjusted in the values file but admittedly, that's because I didn't go through the guide exactly as stated. I made some tweaks here and there that broke compatibility with the values file. Happy to offer some suggestions.
@alexifm would be great if you can help with adding what you changed in this issue which can eventually we can followup with doc changes or values files changes.
Hello 👋, This issue has been inactive for over 9 months. To help maintain a clean and focused backlog, we'll be marking this issue as stale and will close the issue if we detect no activity in the next 7 days. Thank you for your contribution and understanding! 🙏
Hello 👋, This issue has been inactive for over 9 months and hasn't received any updates since it was marked as stale. We'll be closing this issue for now, but if you believe this issue is still relevant, please feel free to reopen it. Thank you for your contribution and understanding! 🙏
Hello 👋, this issue has been inactive for over 9 months. To help maintain a clean and focused backlog, we'll be marking this issue as stale and will engage on it to decide if it is still applicable. Thank you for your contribution and understanding! 🙏
This breaks the https://docs.flyte.org/en/latest/deployment/aws/manual.html#connecting-to-flyte
Now we will have to add:
alb.ingress.kubernetes.io/target-type: 'ip'
in the ingress annotation of value-eks.yaml@brucearctor @EngHabu
RE: https://github.com/flyteorg/flyte/pull/2566 Originally posted by @jw0515 in https://github.com/flyteorg/flyte/issues/2566#issuecomment-1208376512