Open cosmicBboy opened 2 years ago
Could I work on this? @cosmicBboy
can i work on this @cosmicBboy
Hey @cosmicBboy , I have created a PR to fix this https://github.com/flyteorg/flytekit/pull/1219 Please can you check if this is the right way to solve this, so I can go ahead and add the tests as well
I would like to work on this @cosmicBboy
Since @techytushar created a PR already, I assigned the issue to Tushar.
Hello š, this issue has been inactive for over 9 months. To help maintain a clean and focused backlog, we'll be marking this issue as stale and will engage on it to decide if it is still applicable. Thank you for your contribution and understanding! š
Iād like to take on this issue if no one else is working on it.
Currently, only numpy arrays are supported by the numpy type extension. It would be useful to also support scalar data types as well.
So today, this code will not work:
Error:
Problem: flytekit doesn't know how to handle
numpy.<dtype>
scalar types. The code above will show up anywhere where a user wants to aggregate some values using numpy operations (including sklearn, and probably a bunch of others)Of course the user can always do
float(x.mean())
to convert it to a normal float, but then this kills UX because now we're forcing users to modify otherwise functioning code into some flytekit-nitpicky syntax.Potential Solutions
Resources