flyteorg / flyte

Scalable and flexible workflow orchestration platform that seamlessly unifies data, ML and analytics stacks.
https://flyte.org
Apache License 2.0
5.78k stars 659 forks source link

[BUG] flyte workflow execution nodes for dynamic tasks collapse in web UI after completion #3215

Open MattGPT-ai opened 1 year ago

MattGPT-ai commented 1 year ago

Dynamic workflows (using the @dynamic decorator) will expand out the dynamically created tasks in the web UI after they are run, and will be displayed even after completion:

Screen Shot 2022-12-02 at 1 18 01 PM

however, after that same execution is refreshed, that expansion into nodes collapses, and the information of the workflow structure is no longer available:

Screen Shot 2022-12-14 at 8 11 08 PM

here is example code that defines the overall dynamic workflow:

@dynamic
def train_workflow_inner(
    recipe_path: str,
    k_folds: int = 1,
) -> int:

    data_flytedir = data_prep_task(recipe_path=recipe_path, recipe_hash=recipe_hash)

    s = None
    for i in range(k_folds):
        model_and_data_flytedir = training_task(
                data=data_flytedir,
                k_folds=k_folds,
                i_fold=i,
        )
        s = eval_task(data=model_and_data_flytedir)

    return s
welcome[bot] commented 1 year ago

Thank you for opening your first issue here! 🛠

kumare3 commented 1 year ago

Cc @jsonporter

rahul-theorem commented 1 year ago

I've also noticed similar behavior w/ the graph view

github-actions[bot] commented 1 year ago

Hello 👋, This issue has been inactive for over 9 months. To help maintain a clean and focused backlog, we'll be marking this issue as stale and will close the issue if we detect no activity in the next 7 days. Thank you for your contribution and understanding! 🙏

github-actions[bot] commented 1 year ago

Hello 👋, This issue has been inactive for over 9 months and hasn't received any updates since it was marked as stale. We'll be closing this issue for now, but if you believe this issue is still relevant, please feel free to reopen it. Thank you for your contribution and understanding! 🙏

MattGPT-ai commented 3 months ago

Not sure if I should open a new issue, but it appears that the dynamically executed executed tasks don't even expand out at any point. The dropdown arrow to expand the dynamic task appears, and clicking on it changes its orientation, but no subtasks are ever displayed

jeffpicard commented 3 months ago

I would also love to see this fixed :)