flyteorg / flyte

Scalable and flexible workflow orchestration platform that seamlessly unifies data, ML and analytics stacks.
https://flyte.org
Apache License 2.0
5.75k stars 652 forks source link

Cached Dynamic Task No Cache Icon in the execution detail page #3475

Open eugenejahn opened 2 years ago

eugenejahn commented 2 years ago

There are 2 problems:

  1. the first time execute the dynamic task, it won't show cache icon (should show the cache_populated icon) because the api payload doesn;t return any cache status
  2. the second time execute the dynamic task, it will show the cache icon, but it can't expand. because the api payload doesn't return children tasks.

First time executed the dynamic task : (don't have the cache icon) https://demo.nuclyde.io/console/projects/uxsandbox/domains/development/executions/apn7n4p8b8rgbgdccm6r?duration=all

Second time executed the Dyanmic Task: (have the cache icon) https://demo.nuclyde.io/console/projects/uxsandbox/domains/development/executions/arlnv6p6zmqvc8rgxq92?duration=all

Slack Discussion: https://flyte-org.slack.com/archives/CP2HDHKE1/p1655227632603389

eugenejahn commented 2 years ago

for the problem 1, it's backend issue that payload didn't return the cache status in the payload. for the problem 2, the payload is expected that without is_parent value. frontend needs to handle this case. However, the UX for this case is not finalize yet.

eugenejahn commented 2 years ago

The issue is still there. For the cached dynamic task, the first time it executes, UI doesn't show the cache icon. (apparently, it's because backend doesn't return the cache value in the payload )

link: https://demo.nuclyde.io/console/projects/uxsandbox/domains/development/executions/apn7n4p8b8rgbgdccm6r?duration=all

image

And if the same cached dynamic task executes second time, it will have the cache icon. However, it can't expend to see the children tasks.

link: https://demo.nuclyde.io/console/projects/uxsandbox/domains/development/executions/apn7n4p8b8rgbgdccm6r?duration=all

image
github-actions[bot] commented 10 months ago

Hello 👋, this issue has been inactive for over 9 months. To help maintain a clean and focused backlog, we'll be marking this issue as stale and will engage on it to decide if it is still applicable. Thank you for your contribution and understanding! 🙏