flyteorg / flyte

Scalable and flexible workflow orchestration platform that seamlessly unifies data, ML and analytics stacks.
https://flyte.org
Apache License 2.0
5.53k stars 597 forks source link

[Housekeeping] Boilerplate pre-push hook fails in flytectl #4090

Open kamaleybov opened 1 year ago

kamaleybov commented 1 year ago

Describe the issue

Updates to boilerplate trigger automatic pull requests into downstream repos that use it. The last update keeps failing in the pre-push hook script.

The root cause of failure is related to commit sign-off validation. That error is hidden by another one, though, described below.

The current error message seems to indicate that the script is executed via sh, while it should be bash:

.git/hooks/pre-push: 35: Syntax error: redirection unexpected

The redirection below is failing:

      done <<< "$NOT_SIGNED_OFF"

What if we do not do this?

Projects using boilerplate are falling behind in tooling. Certain scripts (e.g., make generate) are failing.

Related component(s)

boilerplate, flytectl

Are you sure this issue hasn't been raised already?

Have you read the Code of Conduct?

welcome[bot] commented 1 year ago

Thank you for opening your first issue here! 🛠

github-actions[bot] commented 3 months ago

Hello 👋, this issue has been inactive for over 9 months. To help maintain a clean and focused backlog, we'll be marking this issue as stale and will engage on it to decide if it is still applicable. Thank you for your contribution and understanding! 🙏