Open eapolinario opened 10 months ago
Thank you for opening your first issue here! 🛠
Hello 👋, this issue has been inactive for over 9 months. To help maintain a clean and focused backlog, we'll be marking this issue as stale and will engage on it to decide if it is still applicable. Thank you for your contribution and understanding! 🙏
Motivation: Why do you think this is important?
Flyteidl changes prior to the monorepo required 2 people to approve the PRs, this is a repo-wide setting. In the monorepo world we're relying on CODEOWNERS files to map ownership, but unfortunately github's implementation doesn't support requiring a minimal number of approvals (as per https://github.com/orgs/community/discussions/22522).
That same github discussion mentions that we can rely on github actions or a bot to implement this.
Goal: What should the final outcome look like, ideally?
Ideally we would be able to combine the expressivity of the existing CODEOWNERS and the requirement of having a minimal number of approvals in PRs.
Describe alternatives you've considered
For sensitive components, e.g. flyteidl, we could have a reduced number of approvers. A big disadvantage of this is the burden put on those in that list.
Propose: Link/Inline OR Additional context
No response
Are you sure this issue hasn't been raised already?
Have you read the Code of Conduct?