search

flyteorg / flyte

Scalable and flexible workflow orchestration platform that seamlessly unifies data, ML and analytics stacks.
https://flyte.org
Apache License 2.0
5.81k stars 661 forks source link

[BUG] Don't drop stack traces #4248

Open iirekm opened 1 year ago

iirekm commented 1 year ago

Describe the bug

In pyflyte run ... I'm getting:

Encountered error while executing workflow ...:
  Error encountered while executing 'train':
  isinstance() arg 2 must be a type, a tuple of types, or a union

Dropping stack traces from console logs is an anti-pattern, making debugging very hard.

Ugly workaround (possible only on local machine): to WorkflowBase.__call__'s except block add: 

            import traceback
            print(traceback.format_exc())

Flytekit version: 1.9.0

Expected behavior

Full stack trace should be preserved.

Additional context to reproduce

No response

Screenshots

No response

Are you sure this issue hasn't been raised already?

Have you read the Code of Conduct?

RRap0so commented 1 year ago

@eapolinario gave it a shot. PTAL :)