search

flyteorg / flyte

Scalable and flexible workflow orchestration platform that seamlessly unifies data, ML and analytics stacks.
https://flyte.org
Apache License 2.0
5.26k stars 557 forks source link

[Housekeeping] Use official mockery library for generating mocks #4934

Open katrogan opened 5 months ago

katrogan commented 5 months ago

Describe the issue

We currently use @EngHabu's 6 year old fork here: https://github.com/search?q=repo%3Aflyteorg%2Fboilerplate%20enghabu&type=code

although upstream now supports OnFoo method declarations and asserting method called expectations: https://github.com/vektra/mockery

What if we do not do this?

Harder to contribute code for newer contributors and the codebase don't get upstream changes

Related component(s)

testing

Are you sure this issue hasn't been raised already?

Have you read the Code of Conduct?

dosubot[bot] commented 5 months ago

🤖

It's great to see your interest in improving the repository! Using the official mockery library for generating mocks would indeed make it easier for newer contributors to understand and contribute to the codebase. Your proposed solution would be a valuable addition. Thank you for considering this improvement!

#### About Dosu This response is meant to be useful and save you time. It is **not meant to be a precise solution**, but rather a starting point for your own research. Help me be more useful! Please leave a 👍 if this is helpful and 👎 if it is irrelevant. If you want to continue the conversation, start your reply with @dosu-bot.