flyteorg / flyte

Scalable and flexible workflow orchestration platform that seamlessly unifies data, ML and analytics stacks.
https://flyte.org
Apache License 2.0
5.17k stars 551 forks source link

Inherit execution cluster label from source execution #5431

Closed va6996 closed 1 week ago

va6996 commented 1 month ago

Tracking issue

Today if a user creates an execution with the execution-cluster-label, then the execution launches in the specified cluster. However, if the workflow has a reference workflow in the workflow, that reference workflow launches in the default cluster since this information isn't passed along. This change fixes that issue by inheriting the cluster label from the source.

Why are the changes needed?

Without this change, part of the workflow will run in cluster 1 and part in cluster 2.

How was this patch tested?

In a local cluster, a workflow was launched with a reference workflow and the reference workflow launched in the correct cluster.

Setup process

Screenshots

Check all the applicable boxes

Related PRs

Docs link

welcome[bot] commented 1 month ago

Thank you for opening this pull request! 🙌

These tips will help get your PR across the finish line:

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 61.08%. Comparing base (25c3596) to head (33eb707). Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #5431 +/- ## ======================================= Coverage 61.07% 61.08% ======================================= Files 793 793 Lines 51226 51229 +3 ======================================= + Hits 31288 31291 +3 Misses 17062 17062 Partials 2876 2876 ``` | [Flag](https://app.codecov.io/gh/flyteorg/flyte/pull/5431/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flyteorg) | Coverage Δ | | |---|---|---| | [unittests-datacatalog](https://app.codecov.io/gh/flyteorg/flyte/pull/5431/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flyteorg) | `69.31% <ø> (ø)` | | | [unittests-flyteadmin](https://app.codecov.io/gh/flyteorg/flyte/pull/5431/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flyteorg) | `58.91% <100.00%> (+<0.01%)` | :arrow_up: | | [unittests-flytecopilot](https://app.codecov.io/gh/flyteorg/flyte/pull/5431/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flyteorg) | `17.79% <ø> (ø)` | | | [unittests-flytectl](https://app.codecov.io/gh/flyteorg/flyte/pull/5431/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flyteorg) | `67.97% <ø> (ø)` | | | [unittests-flyteidl](https://app.codecov.io/gh/flyteorg/flyte/pull/5431/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flyteorg) | `79.04% <ø> (ø)` | | | [unittests-flyteplugins](https://app.codecov.io/gh/flyteorg/flyte/pull/5431/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flyteorg) | `61.94% <ø> (ø)` | | | [unittests-flytepropeller](https://app.codecov.io/gh/flyteorg/flyte/pull/5431/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flyteorg) | `57.32% <ø> (ø)` | | | [unittests-flytestdlib](https://app.codecov.io/gh/flyteorg/flyte/pull/5431/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flyteorg) | `65.82% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flyteorg#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

welcome[bot] commented 1 week ago

Congrats on merging your first pull request! 🎉