flyteorg / flyte

Scalable and flexible workflow orchestration platform that seamlessly unifies data, ML and analytics stacks.
https://flyte.org
Apache License 2.0
5.17k stars 551 forks source link

Make BaseURL insensitive to trailing slashes for metadata endpoint redirect. #5458

Closed Dlougach closed 2 weeks ago

Dlougach commented 3 weeks ago

Tracking issue

Example: Closes #5456

Why are the changes needed?

Fixes resolution of OpenID metadata URL redirect.

Without the change tests would fail:

expected: "https://login.microsoftonline.com/abc/v2.0/.well-known/openid-configuration"
actual  : "https://login.microsoftonline.com/abc/.well-known/openid-configuration"

What changes were proposed in this pull request?

Append a trailing slash to BaseURL before running ResolveReference

How was this patch tested?

Unit tests only.

Setup process

Screenshots

Check all the applicable boxes

Related PRs

Docs link

welcome[bot] commented 3 weeks ago

Thank you for opening this pull request! 🙌

These tips will help get your PR across the finish line:

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 60.98%. Comparing base (25c3596) to head (c0b5033). Report is 2 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #5458 +/- ## ========================================== - Coverage 61.07% 60.98% -0.10% ========================================== Files 793 793 Lines 51226 51313 +87 ========================================== + Hits 31288 31294 +6 - Misses 17062 17134 +72 - Partials 2876 2885 +9 ``` | [Flag](https://app.codecov.io/gh/flyteorg/flyte/pull/5458/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flyteorg) | Coverage Δ | | |---|---|---| | [unittests-datacatalog](https://app.codecov.io/gh/flyteorg/flyte/pull/5458/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flyteorg) | `69.31% <ø> (ø)` | | | [unittests-flyteadmin](https://app.codecov.io/gh/flyteorg/flyte/pull/5458/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flyteorg) | `58.66% <100.00%> (-0.25%)` | :arrow_down: | | [unittests-flytecopilot](https://app.codecov.io/gh/flyteorg/flyte/pull/5458/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flyteorg) | `17.79% <ø> (ø)` | | | [unittests-flytectl](https://app.codecov.io/gh/flyteorg/flyte/pull/5458/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flyteorg) | `67.97% <ø> (ø)` | | | [unittests-flyteidl](https://app.codecov.io/gh/flyteorg/flyte/pull/5458/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flyteorg) | `79.04% <ø> (ø)` | | | [unittests-flyteplugins](https://app.codecov.io/gh/flyteorg/flyte/pull/5458/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flyteorg) | `61.84% <ø> (-0.10%)` | :arrow_down: | | [unittests-flytepropeller](https://app.codecov.io/gh/flyteorg/flyte/pull/5458/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flyteorg) | `57.32% <ø> (ø)` | | | [unittests-flytestdlib](https://app.codecov.io/gh/flyteorg/flyte/pull/5458/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flyteorg) | `65.82% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flyteorg#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

eapolinario commented 2 weeks ago

Thank you!

welcome[bot] commented 2 weeks ago

Congrats on merging your first pull request! 🎉