Closed novahow closed 2 months ago
Attention: Patch coverage is 21.97802%
with 71 lines
in your changes missing coverage. Please review.
Project coverage is 60.54%. Comparing base (
5b0d787
) to head (da3a344
). Report is 1 commits behind head on master.
Files | Patch % | Lines |
---|---|---|
flytectl/pkg/github/provider.go | 20.22% | 68 Missing and 3 partials :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks for your PR. Can you fix the lint errors?
Do we really have to provide real implementations of all these functions in provider.go?
Also, can you add a few unit tests?
Currently I haven't came up with a way to better utilize the original provider, since embedding the original provider didn't seem feasible
Some tests in version_test.go
were not calling TearDown (basically another instance of https://github.com/flyteorg/flyte/issues/5325). Fixed in https://github.com/flyteorg/flyte/pull/5470/commits/da3a344f4978028d9a6b6d0a5a2cff9a4d9bb013.
Tracking issue
closes #5372
Why are the changes needed?
flytectl upgrade is not working after monorepo integration
What changes were proposed in this pull request?
Cloned the code from the original external package https://github.com/mouuff/go-rocket-update/blob/v1.5.4/pkg/provider/provider_github.go , and made modifications to fit our needs
How was this patch tested?
make test_unit
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link