Closed Sovietaced closed 4 days ago
Attention: Patch coverage is 58.33333%
with 5 lines
in your changes missing coverage. Please review.
Project coverage is 60.99%. Comparing base (
c10346d
) to head (f87a1aa
).:exclamation: Current head f87a1aa differs from pull request most recent head 2337fe1
Please upload reports for the commit 2337fe1 to get more accurate results.
Files | Patch % | Lines |
---|---|---|
flytestdlib/otelutils/factory.go | 54.54% | 3 Missing and 2 partials :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@hamersaw @andrewwdye can you plz review this PR?
Closing in favor of: https://github.com/flyteorg/flyte/pull/5504
Tracking issue
Closes https://github.com/flyteorg/flyte/issues/5476
Why are the changes needed?
Distributed traces can only be exported using Jaeger with the current code. The jaeger protocol has been deprecated in favor of the open telemetry protocol (OTLP). Additionally, if we're using OTEL client libraries Flyte should also just support their native protocol as well.
We should also deprecate use of the Jaeger exporter and slate it for removal.
What changes were proposed in this pull request?
This pull request adds two new trace exporter strategies:
otlpGrpc
(OTLP over gRPC) andotlpHttp
(OTLP over HTTP).How was this patch tested?
This patch was tested locally in our non production environment.
Check all the applicable boxes
Related PRs
Docs link