Closed hamersaw closed 2 weeks ago
Attention: Patch coverage is 0%
with 9 lines
in your changes missing coverage. Please review.
Project coverage is 60.99%. Comparing base (
7d788cb
) to head (ddd7c8c
).
Files | Patch % | Lines |
---|---|---|
...g/controller/nodes/array/node_execution_context.go | 0.00% | 9 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Tracking issue
NA
Why are the changes needed?
ArrayNode strips the collection from the output type because it currently relies on registering a separate task with a wrapped collection to satisfy node output validators. The bug is that this stripped did no deep copy, so if multiple nodes stripped the outer collection, we would end up stripping mutliple layers if they existed.
What changes were proposed in this pull request?
In this PR we deep copy the interface of the TaskTemplate to ensure that multiple subNode executions do not strip mutliple
List
from the output variable type.How was this patch tested?
The following workflow is a minimal repro:
Setup process
Screenshots
Check all the applicable boxes
Related PRs
NA
Docs link
NA