Closed andrewwdye closed 3 days ago
Attention: Patch coverage is 45.94595%
with 20 lines
in your changes missing coverage. Please review.
Project coverage is 60.99%. Comparing base (
2334d3f
) to head (d504995
). Report is 2 commits behind head on master.
Files | Patch % | Lines |
---|---|---|
flytestdlib/otelutils/factory.go | 39.39% | 20 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Why are the changes needed?
This changes adds support for OLTP and sampling to the otelutils tracer provider abstraction.
Adds support for OLTP. This is the recommended replacement for the deprecated jaeger exporter.
OLTP supports grpc and http, which are added as separate exporter types and configs.
Adds initial sampling support to the top level open telemetry config. Defaults to parent sampler
always
, but also adds a config for TraceIdRatioBased. See these docs for behavior of parent sampler.How was this patch tested?
Ran local sandbox with local jaeger all-in-one and verified
Flyte config
Jaeger