[Docs] auth setup page issues

davidmirror-ops commented 4 months ago

Description

We need to fix the following problems for the auth setup docs to be more precise:

The steps for MS Entra ID have to be updated to reflect the current location of settings on the Azure UI

The indentation for configmap.adminServer.security is wrong. It should be one level deeper (under server):

configmap:
adminServer:
server:
  httpPort: 8088
  grpc:
    port: 8089
  security:
    secure: false
    useAuth: true
    allowCors: true
    allowedOrigins:
# Accepting all domains for Sandbox installation
      - "*"
    allowedHeaders:
      - "Content-Type"

Step 8 and beyond are folded inside the Note block when it should be out
There have been users indicating that in general, this page is hard to understand. Try to improve verbiage to make it easier to follow.

Are you sure this issue hasn't been raised already?

[X] Yes

Have you read the Code of Conduct?

[X] Yes

runllm[bot] commented 4 months ago

Issue Title: [Docs] auth setup page issues

Issue Body:

Description

We need to fix the following problems for the auth setup docs to be more precise:

The steps for MS Entra ID have to be updated to reflect the current location of settings on the Azure UI.

The indentation for configmap.adminServer.security is wrong. It should be one level deeper (under server):

configmap:
adminServer:
server:
  httpPort: 8088
  grpc:
    port: 8089
  security:
    secure: false
    useAuth: true
    allowCors: true
    allowedOrigins:
      # Accepting all domains for Sandbox installation
      - "*"
    allowedHeaders:
      - "Content-Type"

Step 8 and beyond are folded inside the Note block when it should be out.
There have been users indicating that in general, this page is hard to understand. Try to improve verbiage to make it easier to follow.

Are you sure this issue hasn't been raised already?

[X] Yes

Have you read the Code of Conduct?

[X] Yes

Sources:

This is an AI-generated response and your feedback is appreciated! Please leave a 👍 if this is helpful and 👎 if it is not.

Mention @runllm to ask follow-up questions. See runllm.com for more!

davidmirror-ops commented 2 months ago

Additional findings:

a. Step 3 for flyte-core in the Apply OIDC Configuration section should be changed from manually editing the flyteadmin secret to just adding the following to the values:

flyte-core

flyteadmin:
  secrets:
    oidc_client_secret: <client_secret_from_your_IDP>

Murdock9803 commented 1 month ago

@davidmirror-ops I would love to contribute to this issue, Can you please assign this to me ? 🙌

davidmirror-ops commented 1 month ago

@Murdock9803 looking forward to your contributions!

pranshustuff commented 1 month ago

Hi I have fixed the issues, please review and give me feedback. I hope it isn't an problem that I wasn't assigned this issue.

flyteorg / flyte