runllm[bot]
commented
2 months ago The issue of shortening the Flyte-specific environment variables injected during the pod manufacturing process by Flytepropeller is valid. Flytekit has supported shorter names since version 0.32.0, making the migration to shorter names in the backend feasible. This change can help avoid potential issues with systems that have tight limits on environment variable lengths.
Would you like more details on how to implement this change or any specific part of the process?
Sources:
This is an AI-generated response and your feedback is appreciated! Please leave a 👍 if this is helpful and 👎 if it is not.
Mention @runllm to ask follow-up questions. See runllm.com for more!
Describe the issue
The flyte-specific environment variables injected during the pod manufacturing process by propeller share a long prefix, namely
FLYTE_INTERNAL_.Flytekit has had support for shorter names since version 0.32.0. Migrating to shorter names in the backend should be painless.
In terms of benefits of shorter environment names, it's well known that different systems (e.g. Windows and older versions of bash) have tight limits, sometimes as low as a few KB for all environment variables (including
PATH), so having these long (and wasteful) names only adds insult to the injury.What if we do not do this?
Different systems deal differently with a list of environment variables that cross the system's threshold, ranging from silently truncating environment variables to crashing processes. If we don't do this we are inadvertently contributing to the problem in the long run.
Related component(s)
flytekit, flytepropeller
Are you sure this issue hasn't been raised already?
Have you read the Code of Conduct?