[BUG] Flytekit duplicates env vars when pod template is specified

[LucasZanellaMBTI]

Describe the bug

Containers in pod spec contain duplicate env vars. We can see this problem occur as soon as we define a pod_template and pass it to task decorator.

Expected behavior

Env vars specified and passed via environment param are not being duplicated

Additional context to reproduce

@task(environment={"MY_ENV_VAR": "bug"}, pod_template=PodTemplate())
def hello_world(name: str) -> str:
  pass

pyflyte run --remote hello.py my_wf

Tested on flytekit v1.11.0 & v1.13.7

We spent some time debugging it and it seems problem is caused in func get_serializable_task of flytekit/tools/translator.py. There we see the method get_k8s_pod is called multiple times. Unfortunately, each call appends env vars to every container specified in pod_spec.

Screenshots

Lucas Zanella lucas.zanella@mercedes-benz.com, Mercedes-Benz Tech Innovation GmbH Provider Information

[welcome[bot]]

Thank you for opening your first issue here! 🛠

[ChengyanOo]

Hi @LucasZanellaMBTI, I'd love to work on this issue, could you assign this to me?

[LucasZanellaMBTI]

Hi @ChengyanOo , I'm glad to read that. Unfortunately I cannot assign this PR to anyone as I miss required permissions.

[ChengyanOo]

Hi @ChengyanOo , I'm glad to read that. Unfortunately I cannot assign this PR to anyone as I miss required permissions.

Thanks for your reply man, do you know who should I contact to figure that out?

[LucasZanellaMBTI]

We will try to reach out developers via their slack channel.

[ChengyanOo]

We will try to reach out developers via their slack channel.

Thanks!