flyteorg / flyte

Scalable and flexible workflow orchestration platform that seamlessly unifies data, ML and analytics stacks.
https://flyte.org
Apache License 2.0
5.18k stars 550 forks source link

[Core Feature]Migrate the general Datacatalog go-client to flyteidl #839

Open kumare3 opened 3 years ago

kumare3 commented 3 years ago

Motivation: Why do you think this is important? Datacatalog is a gRPC service. Currently the only go-client for datacatalog is in fytepropeller. But there is motivation in the community to create a simple CLI using flytectl. For this it would be great to have a central place to house the datacatalog go-client. FlyteIDL already houses the gRPC protobuf definition.

Goal: What should the final outcome look like, ideally? FlyteCTL can simply introduce a dependency and the client should work

Proposal There is a PR that started some of this work - https://github.com/flyteorg/flyteidl/pull/2/files FlytePropeller uses a higher level client for its own usage - https://github.com/flyteorg/flytepropeller/tree/master/pkg/controller/nodes/task/catalog

FlyteAdmins client can be used as a template https://github.com/flyteorg/flyteidl/tree/master/clients/go/admin

kumare3 commented 3 years ago

@tnsetting did you get a chance to check this issue out?

tnsetting commented 3 years ago

Hi, @kumare3 , we will start to working on next week.

kumare3 commented 3 years ago

@tnsetting any updates on this?

yindia commented 2 years ago

@tnsetting I want to work on the issue if you are not working on it. CC @kumare3

tnsetting commented 2 years ago

Sure. Please go ahead.

github-actions[bot] commented 10 months ago

Hello 👋, This issue has been inactive for over 9 months. To help maintain a clean and focused backlog, we'll be marking this issue as stale and will close the issue if we detect no activity in the next 7 days. Thank you for your contribution and understanding! 🙏

github-actions[bot] commented 10 months ago

Hello 👋, This issue has been inactive for over 9 months and hasn't received any updates since it was marked as stale. We'll be closing this issue for now, but if you believe this issue is still relevant, please feel free to reopen it. Thank you for your contribution and understanding! 🙏