search

flyve-mdm / ios-inventory-library

Inventory client library written in Swift for developing applications on iOS
http://flyve.org/ios-inventory-library/
Other
8 stars 10 forks source link

Fix vulnerable dependencies #122

Closed Fabianopb closed 6 years ago

Fabianopb commented 6 years ago

Initially npm recognized 7 vulnerable dependencies:

found 7 low severity vulnerabilities in 1823 scanned packages

Luckly they were low severity vulnerabilities and could be fixed via npm audit. So the new result is:

found 0 vulnerabilities
 in 1667 scanned packages

Close: https://github.com/flyve-mdm/ios-inventory-library/issues/121

Fabianopb commented 6 years ago

Hi @ajsb85 sure, commit amended! And thanks for noticing about the email, that was my work email.

ajsb85 commented 6 years ago

Normally we consider npm changes as build commit message type. But it's critical vulnerability so ok to use fix commit message type. But the body does not need to repeat again the fix word. And also the point at the end of the parragraph is not conventinal. But at least it's just a draft of the Changelog for the documenter, marketing and commercial department to write the newsletter and the release note.

Thank you very much for your contribution. There are more vunerablities in the gem lock file waiting to fix.

See you.