Workaround for absence of advisory locks in YugabyteDB

flyway / flyway-community-db-support

Offical Flyway Community Supported Database Plugins

https://flywaydb.org/

Apache License 2.0

5 stars 30 forks source link

Workaround for absence of advisory locks in YugabyteDB #35

Closed ashetkar closed 5 months ago

ashetkar commented 6 months ago

Problem:

YugabyteDB does not support PG Advisory Locks. The Postgresql plugin used these to enforce locking around Flyway operations, and YugabyteDB plugin, which extends it, had to suppress the failure message.

Solution:

Now, the plugin employs the locking based on SELECT...FOR UPDATE through a token row in YB_FLYWAY_LOCK_TABLE.
Also, fixing a bug with respect to using the YugabyteDB Smart driver class name when specified url is jdbc:yugabytedb:

Testing:

Added a new test for these changes in the repository: https://github.com/yugabyte/flyway-tests

ashetkar commented 6 months ago

This PR addresses the locking mechanism and is the next step to this PR from @Sfurti-yb cc @Barry-RG

ashetkar commented 6 months ago

Can someone please take a look at this PR?

ashetkar commented 6 months ago

@Barry-RG A gentle reminder. And also please let me know if we need to create a GitHub issue to move forward on this since we would like to have this change published at the earliest.

CLAassistant commented 6 months ago

All committers have signed the CLA.

ymahajan commented 6 months ago

YugabyteDB PM here - I would appreciate it if you could review and commit this PR, as we have a customer waiting for this change. Thank you.

cc @Barry-RG, @ed-RG, @JasonLuo-Redgate, @sazonov, @madninjaskillz @RedGateAdmin, @edwardcasbon

ashetkar commented 5 months ago

Thanks @Barry-RG. Is this fix part of this package https://github.com/flyway/flyway-community-db-support/packages/2037431 ?