search

flyway / flyway-test-extensions

Apache License 2.0
129 stars 35 forks source link

Flyway 5.1.x support #59

Closed myashchenko closed 5 years ago

myashchenko commented 6 years ago

Any plans for this? It's needed in order to be able to execute flyway in tests which use Spring 5.1.X / Spring Boot 2.1.X

FlorianGWE commented 6 years ago

Plans Yes, but add the moment not many spare time to do this.

Please provide more information, what are the problems. Why flyway-test-extension do not work correct with Spring Boot 2.x and Spring 5.1.

In Spring 5.1 I see not so many changes that the setup of sample for Spring 5 will not work.

myashchenko commented 6 years ago

Spring 5.1 uses Flyway 5.1.X, but the latest version of flyway-test-extension can't work with Flyway 5.1.X because of the following error:

java.lang.NoSuchMethodError: org.flywaydb.core.Flyway.getLocations()[Ljava/lang/String;
    at org.flywaydb.test.FlywayTestExecutionListener.locationsMigrationHandling(FlywayTestExecutionListener.java:444)
    at org.flywaydb.test.FlywayTestExecutionListener.dbResetWithAnnotation(FlywayTestExecutionListener.java:399)
FlorianGWE commented 6 years ago

Ok the missing is to support Flyway 5.1 instead of support for Spring 5.1. Flyway 5.1 brings breaking changes see https://flywaydb.org/documentation/releaseNotes issue 1707 and issue 1928

myashchenko commented 6 years ago

@FlorianGWE so new version of the test extension should handle breaking changes

FlorianGWE commented 5 years ago

pushed to sonatype and released. waiting for promotion to maven central