search

flywheel-io / gears

Flywheel Gear Examples and Documentation
MIT License
6 stars 3 forks source link

Allow manifest url and source fields to be empty #14

Closed kofalt closed 7 years ago

kofalt commented 7 years ago

This is a very simple change that will make tools such as the gear builder a little more relaxed.

We want URLs in manifests to be valid, if they exist, but allowing for an empty string instead of the valid dummy value http://example.example is a lot more human-friendly :)

ryansanford commented 7 years ago

Seems like a requirement as well for proprietary gears. 👍

kofalt commented 7 years ago

@ryansanford Not so; the dummy value is currently used instead. The URLs also don't have to be externally routable. But at any rate this is far nicer :)

Go ahead and github-approve this change if it LGTU.

kofalt commented 7 years ago

Added a PR template because why not. Ref #7.

@gsfr does this have exchange implications? We discussed checking for valid URLs at one point.

kofalt commented 7 years ago

I went ahead and checked the exchange; we're good there.

It uses the master copy of this repo, so upon merge the exchange will start accepting the new option.

gsfr commented 7 years ago

And an apology from me for being so far behind on GitHub.

kofalt commented 7 years ago

No worries :)