search

flywheel-io / gears

Flywheel Gear Examples and Documentation
MIT License
6 stars 3 forks source link

Restructuring #6

Closed gsfr closed 7 years ago

gsfr commented 7 years ago

This is a restructuring and cleanup PR. Most importantly, it updates the package name to match the repo name. When I do pip install ...gears, I fully expect to be able to import gears. Incidentally, this leads to a name collision in scitran/core, which I'm addressing separately over there.

I'm also adding a command line entry point for invocation schema generation, which I'm using in flywheel/exchange.

kofalt commented 7 years ago

Mostly LGTM with a few questions. I don't have a strong opinion on the name, though it does feel weird to me to have the gears repo have a gears folder in it.

gsfr commented 7 years ago

Thanks for the review, @kofalt.

The double folder hierarchy is standard Python naming convention.

http://the-hitchhikers-guide-to-packaging.readthedocs.io/en/latest/creation.html

kofalt commented 7 years ago

Cool. LGTM, merge as desired.

gsfr commented 7 years ago

Thanks. I'll hold off until @nagem or you sign off on scitran/core#559.

gsfr commented 7 years ago

@ryansanford Can we merge this now in prep for scitran/core#559?