search

flywheel-io / hpc-client

Cast jobs to an on-premise HPC.
MIT License
3 stars 4 forks source link

slurm.py (probably others) access wrong part of the job.config #11

Open bloyl opened 2 years ago

bloyl commented 2 years ago

Just bumped into this.

in slurm.py and presumably sge.py etc. the base code seems to look in the job.config for parameters.

https://github.com/flywheel-io/hpc-client/blob/88f61e1aa49b336485c17fb669b0e94a08ada475/code/cluster/slurm.py#L29-L30

I think this is incorrect since job.config is config.json so the actual parameters are in job.config['config']

jiavila commented 1 year ago

Being resolved in 2.0.0.