search

flyx / NimYAML

YAML implementation for Nim
https://nimyaml.org
Other
191 stars 36 forks source link

Fix compilation in debug mode #52

Closed Calinou closed 6 years ago

Calinou commented 6 years ago

I investigated a build issue with @dom96 and fixed it by changing internalError from a template to a proc.

This is untested in real world use cases, I don't know if it breaks things; please test first before merging.

flyx commented 6 years ago

This fix is wrong because changing internalError to a proc would make the instantiationInfo useless as it would always report the source line of the the proc instead of the actual line in the code where the error occurs.

Also, when creating a PR, please describe the problem you intend to fix. I currently have little time and would be grateful if I wouldn't need to dig through the IRC log to get an error description ;).

flyx commented 6 years ago

obsolete with #56